WIP: Support OS version in platform string #5614
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/dockerfile
area/llb
area/testing
area/dependencies
cpuguy83
force-pushed
the
platforms_format_all
branch
6 times, most recently
from
688785a to
171ad5b
Compare
profnandaa
reviewed
Jan 7, 2025
| @@ -9327,6 +9328,140 @@ COPY Dockerfile /foo | |||
| } | |||
| } | |||
|
|
|||
| func testPlatformWithOSVersion(t *testing.T, sb integration.Sandbox) { | |||
There was a problem hiding this comment.
thinking of a workaround to test this on Windows, given we don't have support for scratch and the unionfs-like mounting... shouldn't be blocking if it's the only one pending, we can skip on Windows for now and file tracking issue on me.
cpuguy83
force-pushed
the
platforms_format_all
branch
5 times, most recently
from
a881f71 to
33ecd88
Compare
|
@cpuguy83 Added this to v0.19 , RC planned for 01/10 |
cpuguy83
force-pushed
the
platforms_format_all
branch
from
33ecd88 to
1646474
Compare
This allows platforms following the new `platforms.FormatAll` function, which allows for setting the `OSVersion` field of the platform with `<os>(<ver>)/<arch>`. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
platforms_format_all
branch
from
1646474 to
212a947
Compare
|
Upstreaming those vendor changes at containerd/platforms#22 |
profnandaa
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows platforms following the new
platforms.FormatAllfunction, which allows for setting theOSVersionfield of the platform with<os>(<ver>)/<arch>.Closes #5115
Note: In order to make
FROM <img>match the correct OS version with the new platform format some changes need to be made to containerd/platforms (see vendor/ changes).